fix(ast): misc estree compat #8950
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #8950 will not alter performanceComparing Summary
|
b6833d4 to
c10f5aa
Compare
|
Usually, I would prefer a PR like this to be broken up into multiple PRs, each showing their effect on the conformance snapshot. But in this case I guess it's not important! We have a lot to fix, so smashing out a bunch of them in one PR is all good. Anyway, I think we should merge #8958 and #8965 first, as they affect a large number of the tests. @hi-ogawa Do you have ability to use Graphite for stacked PRs in Oxc repo? If you're not set up in Oxc graphite "team" already, I'll try to sort that out. |
|
@overlookmotel It looks like I can use graphite here already 👍 I'll split the PRs and close this one. |
on top of #8946part of #2854
For the first round, I fixed the incompatibility found by @sapphi-red in Vite's ssr transform (cf. vitejs/rolldown-vite#81). I can split and stack PRs if that's desired.