Redesign Transaction V5 serialization #88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's easy to accidentally serialize V5 transaction fields in the wrong order. So we should go back to the design stage for V5 transaction serialization.
Solution
Output
s in the V4 format in V5 transactions, add a wrapper type, and move the serialization impls to that typeThe code in this pull request has:
Review
@oxarbitrage should review, because it blocks ZcashFoundation#1996
@dconnolly might also want to have a look, because it's a redesign.
Follow Up Work
Add the serialization impls to the implementation section of ZcashFoundation#1829 and ZcashFoundation#1979 (done!)