Update munki_rebrand.py #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be needed if munki/munki#1203 is merged into Munki
|
just saw this pending commit for 6.6: munki/munki@dc2725e is this PR still good to address? |
|
It’s needed for: https://github.com/munki/munki/releases/tag/v6.6.0b1 |
|
I encountered this because I got an error FYI: You do not get this error if you don't specify a custom icon file, because then munki-rebrand will not attempt to replace files in the paths that have changed. I don't know if this will cause errors in the buil pkg, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed if munki/munki#1203 is merged into Munki