Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change role dropdown #8882

Merged
merged 15 commits into from
Apr 26, 2023
Merged

Change role dropdown #8882

merged 15 commits into from
Apr 26, 2023

Conversation

hurradieweltgehtunter
Copy link
Contributor

Description

Screenshots (if appropriate):

Before

grafik

After

grafik

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 20, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@hurradieweltgehtunter hurradieweltgehtunter self-assigned this Apr 20, 2023
@hurradieweltgehtunter hurradieweltgehtunter added the Status:Needs-Review Needs review from a maintainer label Apr 20, 2023
@hurradieweltgehtunter hurradieweltgehtunter mentioned this pull request Apr 21, 2023
Open
13 tasks
kulmann
kulmann approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you 💪 As you said, tests need to be adjusted regarding changed roles. As soon as CI is green we can merge this.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 👍

@kulmann kulmann merged commit 3cfe10f into master Apr 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the change-role-dropdown branch April 26, 2023 10:24
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@tbsbdr tbsbdr Awaiting requested review from tbsbdr

Assignees

@hurradieweltgehtunter hurradieweltgehtunter

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[share-dialog-redesign] I: Section "Share with people"
2 participants
@hurradieweltgehtunter @kulmann