Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle postprocessing file state in apps & actions #8069

Closed
wants to merge 6 commits into from

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Dec 5, 2022

Description

Backport async upload handling from the experimental branch.

Already done / extracted to another PR

#8146

  • update owncloud-sdk after we're able to build a new release artifact from owncloud-sdk repo
  • allow elements with 425-too early in listFiles, but introduce Resource attribute processing

Open tasks:

  • handle 425 in all the apps. show too early-message for:
    • PROPFIND depth 0 in web-app-draw-io
    • POST to app open endpoint in web-app-external
    • PROPFIND depth 0 in web-app-pdf-viewer
    • preview in web-app-preview
    • PROPFIND depth 0 in web-app-text-editor
  • handle 425 in all file actions:
    • download
    • archive download
    • copy (= paste after copy)
    • move (= paste after cut)
    • rename
    • delete
  • what about handling a single 425 file in batch actions?
  • add unit tests

Open tasks backend:

  • preview request returns http 500 in postprocessing
  • webdav GET returns http 500 in postprocessing (not a blocker for this PR, as we have PROPFINDs before the respective GETs)

Followup tasks:

  • happy path e2e tests

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Dec 5, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the backport-async-uploads branch 5 times, most recently from 406c02d to eb77ad2 Compare December 12, 2022 20:38
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

36.6% 36.6% Coverage
0.8% 0.8% Duplication

@kulmann kulmann force-pushed the backport-async-uploads branch 3 times, most recently from 5b1b48a to c725b8e Compare December 19, 2022 19:53
@kulmann kulmann force-pushed the backport-async-uploads branch from c725b8e to c9034b2 Compare December 21, 2022 16:01
@kulmann kulmann force-pushed the backport-async-uploads branch from c9034b2 to 066d35c Compare December 22, 2022 14:10
@kulmann kulmann changed the title Backport async uploads Hand postprocessing file state in apps & actions Dec 22, 2022
@kulmann kulmann changed the title Hand postprocessing file state in apps & actions Handle postprocessing file state in apps & actions Dec 22, 2022
@kulmann kulmann closed this Oct 30, 2023
@kulmann kulmann deleted the backport-async-uploads branch October 30, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant