-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Import owncloud-design-system #7940
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Kind of I guess, give it a try. You need to run build:system and maybe need to restart rollup... but haven't tested it myself |
ab52140
to
738ff38
Compare
Results for oC10Files5 https://drone.owncloud.com/owncloud/web/29921/21/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFilesActionMenu-versions_feature-L15.pngwebUIFilesActionMenu-versions_feature-L26.pngwebUIFilesActionMenu-versions_feature-L46.pngwebUIFilesActionMenu-versions_feature-L74.pngwebUIFilesActionMenu-versions_feature-L90.png |
92408cc
to
c1b806b
Compare
c1b806b
to
e37f3c3
Compare
ed7cb31
to
6079d5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes, so that this PR can't be merged accidentally. The design system has contradicting license information in its repo. There is a license file which states Apache2.0, and the package.json claims that its licensed under AGPL-3.0. Needs to be clarified before we can merge.
We consciously decided against importing the history: it's quite huge, contains a lot of bloat (e.g. UiKit assets) and because of the reformatting git blame is only useful with some effort.
6079d5c
to
5530b9b
Compare
SonarCloud Quality Gate failed. 8 Bugs |
Has been clarified internally with @hodyroff - there was the idea of moving towards Apache2.0 in the design system, but apparently never executed completely/correctly and the CLA bot for the AGPL was always active. Moving the design system over to the web monorepo (= this PR) will revert the incomplete license transition back to AGPL. |
This PR imports the owncloud-design-system from owncloud/owncloud-design-system#2367 and renames it to
@ownclouders/design-system
, to be consistent with@ownclouders/web-pkg
and@ownclouders/web-client
.It's built as part of the regular rollup dev server and production builds, so no separate build step is neccessary anymore.
The documentation built is unfortunately broken, but we decided to postpone fixing it a bit, as we still have to sort out publishing separate packages from our monorepo. We probably just need to make vue-styleguidist/webpack aware of TypeScript and everything should work again.
This PR is standing on shoulders of giants, mainly @pascalwengerter and @fschade.
Kudos for preparing https://github.com/owncloud/owncloud-design-system/pull/1888/files, took a lot of inspiration from that one.
Tasks
@ownclouders/design-system
Followup Tasks
further reference
owncloud/owncloud-design-system@master...migrate-to-vue-3