Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Search improvements 2 #7634

Merged
merged 41 commits into from
Sep 20, 2022
Merged

[full-ci] Search improvements 2 #7634

merged 41 commits into from
Sep 20, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 12, 2022 •
edited
Loading

Description

image

  • Change architecture, so multiple providers are possible
  • Add mark.js
  • Redesign preview
  • Show 'No results found' with lupe icon in search list
  • Decrease search time out to 100ms

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Sep 12, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the base branch from master to search-improvements-1 September 13, 2022 23:46
@AlexAndBear AlexAndBear mentioned this pull request Sep 14, 2022
Closed
@delete-merged-branch delete-merged-branch bot deleted the branch master September 14, 2022 10:54
@AlexAndBear AlexAndBear changed the base branch from search-improvements-1 to master September 14, 2022 10:55
Jan added 24 commits September 14, 2022 12:58
Search improvements
bc5c6e3
Fix unit tests
55eb35a
Fix unit tests
e0e967e
Fix unit tests
d4189e8
Fix download file not possible
d1c5d6e
Remove unused code
faf2bcc
Omit user management search, add user managemenr filter
f3a7e25
Default actions are not executable while browsing on routes like tras…
1112ff4 
…hbin and using the search
Add scrollbar if preview list gets to long
54c3a2f
Make filter smaller
2858d6c
Increase search limit
120ee51
Skip tests, will rewrite the later anyways
a268d46
React on code review
18a7a01
React on code review 2
b948245
React on code review 4
3b5b87f
Fix unit tests
b7c7ea9
Fix unit tests
8e96522
Improve
4712264
Implement markjs
8a5bccc
User range easier
f0bee16
Add dummy provider
fe0827e
Only show providers with results
9829889
Fix click on preview item has no effect
30aabca
Remove not necesserary search methods
6e96052
@AlexAndBear AlexAndBear changed the title Search improvements 2 [full-ci] Search improvements 2 Sep 19, 2022
@AlexAndBear AlexAndBear marked this pull request as ready for review September 19, 2022 15:08
@ownclouders
Copy link
Contributor

ownclouders commented Sep 19, 2022 •
edited
Loading

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/28437/72/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesSearch-search_feature-L27.png

webUIFilesSearch-search_feature-L27.png

@fschade
Copy link
Contributor

fschade commented Sep 19, 2022

Haven’t had time to review it… just wanna react to the provided screenshot… holy molly, that’s 🔥 thank you ❤️

@AlexAndBear
Copy link
Contributor Author

Haven’t had time to review it… just wanna react to the provided screenshot… holy molly, that’s fire thank you heart

<3

@AlexAndBear
Copy link
Contributor Author

TBD in follow up pr:

  • Enable keyboard navigation
  • Rewrite unit tests

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.5% 22.5% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if you want to include the PR link in an existing changelog item. In any case, this PR is a massive improvement. Both visually and technically. WOW dude! ❤️

@kulmann kulmann merged commit f99283f into master Sep 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the search-improvements-2 branch September 20, 2022 07:57
@AlexAndBear
Copy link
Contributor Author

@kulmann Search improvement was kind of a moving target. I like to add a changelog item with all the recent PRs with the final PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @ownclouders @fschade @kulmann