Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces overview refinement #6399

Merged
merged 13 commits into from
Feb 10, 2022
Merged

Spaces overview refinement #6399

merged 13 commits into from
Feb 10, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 9, 2022

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/22606/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:63

@owncloud owncloud deleted a comment from update-docs bot Feb 9, 2022
@kulmann kulmann mentioned this pull request Feb 9, 2022
25 tasks
@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22616/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22616/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:253

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22616/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really good improvement! Found some small issues. Also see attached screenshot: the three dots button in the spaces overview is not perfectly aligned vertically. And you need to add additional padding above the footer row of the card (below the hairline) because it looks off by the pixels that you have for the border radius at the bottom. ;-)

Screenshot 2022-02-10 at 09 46 54

packages/web-app-files/src/views/spaces/Projects.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/spaces/Projects.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/spaces/Projects.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/spaces/Projects.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/spaces/Projects.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from kulmann February 10, 2022 09:33
@JammingBen JammingBen requested a review from kulmann February 10, 2022 09:45
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🥳 🥳

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit d498c17 into master Feb 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-overview-refinement branch February 10, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaces list page: Heading overflows tile Spaces polishing
4 participants