-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces overview refinement #6399
Conversation
Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/22606/65/1
|
…into spaces-overview-refinement
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22616/15/1
|
Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22616/55/1
|
Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22616/60/1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall really good improvement! Found some small issues. Also see attached screenshot: the three dots
button in the spaces overview is not perfectly aligned vertically. And you need to add additional padding above the footer row of the card (below the hairline) because it looks off by the pixels that you have for the border radius at the bottom. ;-)
packages/web-app-files/tests/unit/views/spaces/__snapshots__/Projects.spec.js.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 🥳 🥳
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: