Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sidebarnavitem text hover color #6366

Merged
merged 1 commit into from
Feb 9, 2022
Merged

fix sidebarnavitem text hover color #6366

merged 1 commit into from
Feb 9, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 3, 2022

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Feb 3, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter mentioned this pull request Feb 9, 2022
Closed
24 tasks
@pascalwengerter pascalwengerter changed the base branch from master to small-fixes-for-v5 February 9, 2022 09:22
@pascalwengerter pascalwengerter marked this pull request as ready for review February 9, 2022 09:24
@lookacat @pascalwengerter
fix sidebarnavitem text hover color
15dc9ba 
Add changelog, remove duplicate text-decoration
pascalwengerter
pascalwengerter approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this into my preliminary design fixes PR, looked good to me

@pascalwengerter pascalwengerter merged commit 954217c into small-fixes-for-v5 Feb 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the design-polish-hover branch February 9, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lookacat @pascalwengerter