Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rounded corners to left sidebar #6365

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Add rounded corners to left sidebar #6365

merged 5 commits into from
Feb 4, 2022

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Feb 3, 2022

Description

Left sidebar now has rounded corners on the right. Also removed some unneeded css classes and styles.

Related Issue

Motivation and Context

Redesign

Screenshots (if appropriate):

Screenshot 2022-02-03 at 17 09 09

Screenshot 2022-02-03 at 17 09 13

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Feb 3, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/22427/42/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:378

pascalwengerter
pascalwengerter reviewed Feb 3, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we're there yet, rounded corners look good but the removed background colors create some (new) glitches from what I witness

packages/web-app-files/src/views/LocationPicker.vue Outdated
@@ -486,7 +486,6 @@ export default {
height: auto;
z-index: 1;
grid-area: header;
background-color: var(--oc-color-background-default);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very weird behaviour when moving a file and scrolling (given enough files in the target folder). Row background colors are different for files&folders, also glitchy in the AppBar (which now is transparent)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files are disabled as a target in copy/move scenarios, that's why they have different colors in the LocationPicker view. Fixed the transparent background of the AppBar.

packages/web-app-files/src/components/SideBar/SideBar.vue Outdated
@@ -330,7 +330,6 @@ export default {
max-height: 100%;
display: grid;
grid-template-rows: 50px 70px 1fr;
background-color: var(--oc-color-background-default);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the expanding sub-panels create a weird overlay situation during the animation...

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22441/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22441/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/22441/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

pascalwengerter
pascalwengerter approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☑️

@pascalwengerter pascalwengerter merged commit ece1045 into master Feb 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the rounded-corners-sidebar branch February 4, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulmann @ownclouders @pascalwengerter