Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save preferred theme in localStorage #6350

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Save preferred theme in localStorage #6350

merged 3 commits into from
Feb 2, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Feb 1, 2022 •
edited by kulmann
Loading

Description

Code doesn't read that nicely but does what it should (comment from before we switched to composition api)

Related Issue

@pascalwengerter pascalwengerter force-pushed the save-themeswitcher-localstorage branch from 1ad7155 to 8d33932 Compare February 1, 2022 17:20
@kulmann kulmann force-pushed the save-themeswitcher-localstorage branch from a06a3cc to c0154ab Compare February 2, 2022 15:22
kulmann
kulmann approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit fishy that I approve this, but LGTM 👍

@ownclouders
Copy link
Contributor

Results for oC10iPhone3 https://drone.owncloud.com/owncloud/web/22371/49/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@kulmann kulmann force-pushed the save-themeswitcher-localstorage branch from c0154ab to af28367 Compare February 2, 2022 15:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.1% 83.1% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit db5a8d2 into master Feb 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the save-themeswitcher-localstorage branch February 2, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add possibility to switch dark/light theme
3 participants
@pascalwengerter @ownclouders @kulmann