-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] enable lazy table cells and fix tests #6204
Conversation
Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/21471/37/1 |
Results for oC10Files2 https://drone.owncloud.com/owncloud/web/21471/17/1 |
36753f4
to
4326974
Compare
Currently blocked by #6142 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See comment about the option name
- Please add a line to the docs about the new option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't comment on the code quality since it'll rebased anyhow after the icons have been changed, but feels amazing in the UI already!
Would it be an improvement to switch to lazy loading of rows
instead of cells
from a UX perspective?
Would be an additional improvement, but for now the cells are good. The extra work is better spent in cleaning up the vuex store. |
4326974
to
194370e
Compare
Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/21555/32/1 |
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21557/15/1
|
Restarting CI, only a single pipeline failed and that one works fine locally... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want to have the dockerized configs with or without lazy tables. But that can be decided later on as well. PR is good to go from my POV 👍
936e357
to
f5da318
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
since lazy table cell rendering has landed in ODS we also should use it in web. the feature is enabled by default, but can be disabled via the configuration (
"resourceTableLazy": false
).Related Issue
Motivation and Context
as written in linked issue, current views kinda slow and should be snappy instead. This is just one piece of it and wiill need further investigation.
How Has This Been Tested?
Types of changes
Checklist: