Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Init store and auth as early as possible #5874

Merged
merged 4 commits into from
Oct 5, 2021
Merged

[full-ci] Init store and auth as early as possible #5874

merged 4 commits into from
Oct 5, 2021

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Oct 4, 2021 •
edited
Loading

Description

Applications need e.g. capabilities in their respective ready() and
mounted() hooks. This commit ensures that they are already loaded when
applications get initialized.

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann
Init store and auth as early as possible
c2376d8 
Applications need e.g. capabilities in their respective ready() and
mounted() hooks. This commit ensures that they are loaded when
applications get initialized.
@kulmann kulmann self-assigned this Oct 4, 2021
@ownclouders
Copy link
Contributor

Results for oC10NotificationBasic https://drone.owncloud.com/owncloud/web/19397/37/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

fschade
fschade approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two little things, else LGTM 🚀

packages/web-runtime/src/container/bootstrap.ts Show resolved Hide resolved
packages/web-runtime/src/container/bootstrap.ts Outdated Show resolved Hide resolved
@kulmann kulmann mentioned this pull request Oct 4, 2021
Merged
14 tasks
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic https://drone.owncloud.com/owncloud/web/19399/61/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@kulmann kulmann mentioned this pull request Oct 4, 2021
Closed
25 tasks
@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/19400/53/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@kulmann kulmann changed the title Init store and auth as early as possible [full-ci] Init store and auth as early as possible Oct 5, 2021
@kulmann kulmann force-pushed the fetch-capabilities-early branch from ccce45f to 4bd2e42 Compare October 5, 2021 04:38
@kulmann
Copy link
Contributor Author

kulmann commented Oct 5, 2021

Acceptance tests have one stable failure for both oc10 and ocis in tests/acceptance/features/webUIFilesSearch/search.feature:38

@fschade
use ready hook to register needed pieces in files app, since we have …
7d3a9d7 
…the ready hook now its reccomended to run all bootstrap operations there
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

11.8% 11.8% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19417/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@fschade fschade merged commit aded87b into master Oct 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the fetch-capabilities-early branch October 5, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulmann @ownclouders @fschade