Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate sticky sidebar header #5266

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Jun 15, 2021

Description

Sticky sidebar header (changes in web are minimal and just reflect what has changed in the ODS)

Related Issue

Motivation and Context

See changelog item in owncloud/owncloud-design-system#1384 and #2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@update-docs
Copy link

update-docs bot commented Jun 15, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter force-pushed the 15062021_sticky-filesapp-sidebar-header branch from fd60dd4 to 884d36f Compare June 15, 2021 10:44
@ownclouders
Copy link
Contributor

💥 Acceptance tests XGAPortrait2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests XGAPortrait1-Notifications failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests XGAPortrait1 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingExternal failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests oc10-integration-notifications failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingExternalRoot failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests IntegrationApp2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests IntegrationApp1 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersBlacklisted failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16297/

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-26.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-26.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-44.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-44.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-62.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-62.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-80.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-80.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-92.png

webUISharingInternalUsersBlacklisted-shareWithUsers-feature-92.png

💥 Acceptance tests SharingInternalUsersBlacklisted failed. The build is cancelled...

@pascalwengerter pascalwengerter force-pushed the 15062021_sticky-filesapp-sidebar-header branch from b55f123 to d51e63b Compare June 17, 2021 14:47
@pascalwengerter pascalwengerter marked this pull request as ready for review June 17, 2021 14:47
@pascalwengerter pascalwengerter changed the title Accommodate sticky sidebar header, update test selectors for it Accommodate sticky sidebar header Jun 17, 2021
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 nice

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16471/

webUIMarkdownEditor-markdownFile-feature-26.png

webUIMarkdownEditor-markdownFile-feature-26.png

💥 Acceptance tests webUIFiles1 failed. The build is cancelled...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter merged commit 39e633f into master Jun 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the 15062021_sticky-filesapp-sidebar-header branch June 17, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header of sidebar needs to be sticky
4 participants