Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch share again via OCS request if it's not in the response #4988

Merged
merged 5 commits into from
May 6, 2021
Merged

Fetch share again via OCS request if it's not in the response #4988

merged 5 commits into from
May 6, 2021

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Apr 20, 2021 •
edited
Loading

Description

In oCIS we don't return the share in the response of the accept/decline shares request. Therefore we have to fetch the share again after the action to update the share information on the screen.

Related Issue

Motivation and Context

How Has This Been Tested?

  • drone

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann requested a review from pascalwengerter April 20, 2021 15:38
@kulmann kulmann marked this pull request as draft April 20, 2021 15:38
@kulmann kulmann self-assigned this Apr 20, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14886/

20210420-155723-841.png
20210420-155757-621.png
20210420-155829-891.png
20210420-155904-322.png

@kulmann kulmann force-pushed the fix-updating-share-after-action branch from 09a0935 to a6b0711 Compare April 27, 2021 14:50
@kulmann kulmann force-pushed the fix-updating-share-after-action branch from a6b0711 to 6e7d79a Compare April 27, 2021 14:54
@kulmann kulmann changed the title [WIP] Fetch share again via OCS request if it's not in the response Fetch share again via OCS request if it's not in the response Apr 27, 2021
@kulmann kulmann marked this pull request as ready for review April 27, 2021 14:59
fschade and others added 2 commits April 28, 2021 23:21
@fschade
refactor root unit test stub location
fd631e6 
add mocks for styles
mock cross-fetch and sync-fetch to make owncloud-sdk work
add test for SharedWithMe.vue
@kulmann
Use share.shareInfo for updating shared with me table
14329a5
@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15302/

20210505-130639-722.png
20210505-130813-973.png
20210505-130845-531.png
20210505-130916-453.png
20210505-131034-539.png
20210505-131155-029.png
20210505-131208-375.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15327/

webUIMoveFilesFolders-moveFiles-feature-105.png

C0rby
C0rby approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kulmann kulmann merged commit db33c2b into master May 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-updating-share-after-action branch May 6, 2021 20:51
@kulmann kulmann mentioned this pull request May 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kulmann @ownclouders @C0rby @fschade