Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media viewer and draw-io to default apps #4493

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

LukasHirt
Copy link
Collaborator

When release tarballs are created, we are copying the config.json.dist into them as a default config. This file had so far only "files" app enabled. This adds also "media viewer" and "draw-io" into apps enabled by default.

@LukasHirt LukasHirt requested a review from micbar December 14, 2020 16:21
@LukasHirt LukasHirt self-assigned this Dec 14, 2020
@update-docs

This comment has been minimized.

@phil-davis
Copy link
Contributor

Failed 1 scenario: https://drone.owncloud.com/owncloud/web/12265/6/20
1) Scenario: Delete all files at once (attempt 2) # tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature:66

IMO that test might be subject to timing errors sometimes???

Restarted drone.

@LukasHirt
Copy link
Collaborator Author

IMO that test might be subject to timing errors sometimes???

Delete ops are limited to 4 requests at the time via p-queue so I guess that's possible that if the CI performance would slow down a bit that it could not delete all files in time.

@phil-davis phil-davis merged commit 911b142 into master Dec 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the default-apps branch December 15, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants