Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic client registration #4306

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Fix dynamic client registration #4306

merged 2 commits into from
Nov 13, 2020

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Nov 12, 2020

Description

There was a bug where page load was failing when not using oidc, but plain oauth2 instead. This PR fixes it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Nov 12, 2020
@kulmann kulmann self-assigned this Nov 12, 2020
@kulmann kulmann merged commit 2976b58 into master Nov 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-dynamic-client-registration branch November 13, 2020 08:35
@phil-davis phil-davis mentioned this pull request Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @LukasHirt