Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable user menu #4133

Merged
merged 5 commits into from
Oct 6, 2020
Merged

Customizable user menu #4133

merged 5 commits into from
Oct 6, 2020

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Oct 6, 2020

Description

This PR makes navigation items customizable with regard to which menu they appear in. By default, anything appears in the app switcher. You can define a menu: "user" in applications in config.json or in the exported navItems of applications. With a separate PR for ocis, the settings and accounts UI will appear in the user menu by default.
Also:

  • We took the chance to add icons to menu items and rename the Manager your account menu item to Profile - which is a better fit, because it just shows read only information.
  • We replaced the Logout button on the profile page with an Edit button which links to the oc10 personal settings if those are available and to the settings UI if that is available.

In case you want to add a nav item to the user menu manually, you can do so via the config.json file:

"applications": [
          {
                "title": {"en": "Settings"},
                "icon": "application",
                "url": "http://host.docker.internal/px1/index.php/settings/personal",
                "target": "_self",
                "menu": "user"
          }
]

Motivation and Context

Improve navigation UX and bridge setup.

Screenshots (if appropriate):

Screenshot 2020-10-06 at 13 05 46

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Oct 6, 2020
@kulmann kulmann requested a review from LukasHirt October 6, 2020 14:07
@kulmann kulmann self-assigned this Oct 6, 2020
@update-docs

This comment has been minimized.

Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit 9e8225f into master Oct 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the menu-structure branch October 6, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants