Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline around files list #3752

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Remove outline around files list #3752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/files/src/components/FilesApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<div
ref="filesListWrapper"
tabindex="-1"
class="uk-width-expand uk-overflow-auto uk-height-1-1"
class="uk-width-expand uk-overflow-auto uk-height-1-1 files-list-wrapper"
:class="{ 'uk-visible@m': _sidebarOpen }"
@dragover="$_ocApp_dragOver"
>
Expand Down Expand Up @@ -171,3 +171,9 @@ export default {
}
}
</script>

<style scoped>
.files-list-wrapper:focus {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is not an ODS component I am putting the styles in here on purpose.

outline: none;
}
</style>
8 changes: 8 additions & 0 deletions changelog/unreleased/files-list-outline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Change: Do not display outline when the files list is focused

The files list was displaying outline when it received focus after a click.
Since the focus is meant only programatically, the outline was not supposed to be displayed.

https://github.com/owncloud/phoenix/issues/3747
https://github.com/owncloud/phoenix/issues/3551
https://github.com/owncloud/phoenix/pull/3752