Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension name for top bar on broken applications #3376

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Fix extension name for top bar on broken applications #3376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/3376
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Fix name of selected extension on broken apps

With the edge case of a broken app in config.json, the top bar is broken, because appInfo can't be loaded.
We made ocis-web more robust by just showing the extension id in the top bar when the appInfo is not available.

https://github.com/owncloud/phoenix/pull/3376
5 changes: 4 additions & 1 deletion src/components/Top-Bar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ export default {
},

currentExtensionName() {
return this.$gettext(this.apps[this.currentExtension].name)
if (this.apps[this.currentExtension]) {
return this.$gettext(this.apps[this.currentExtension].name)
}
return this.currentExtension
}
},
methods: {
Expand Down