Resharers now visible on top of owner entry #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
reviewed
Feb 21, 2020
|
I like the |
|
Feels a bit odd to me seeing there twice the same name in case of the same owner and sharer.
|
bug in this PR |
3a5dc09 to
1fb8150
Compare
|
|
@kulmann @LukasHirt please re-review I grew tired of |
|
kulmann
previously requested changes
Feb 21, 2020
LukasHirt
reviewed
Feb 24, 2020
61e89ba to
83baccc
Compare
|
PR adjusted according to comments and checkboxes |
LukasHirt
reviewed
Feb 25, 2020
LukasHirt
reviewed
Feb 25, 2020
83baccc to
3123701
Compare
|
|
|
Possibly related failures:
|
3123701 to
492e5a7
Compare
|
fixed the test issue: the selector for the collaborator name was confused because the reshare popup was using the same class name. Fixed by using a different class name in the popup. |
|
Remaining failure:
|
492e5a7 to
97ea1cf
Compare
|
Adjusted. Expecting CI to pass. Then it's done expect for the extra height due to missing ODS update. |
13 tasks
For received shares, the resharers user display names are now shown on top of the owner entry in the collaborators list, with a reshare icon, instead of having their own entry in the collaborators list. Moved reshare related tests to the reshare feature file.
97ea1cf to
d7205e9
Compare
|
rebased to get the ODS update and restart the build due to setup failure |
LukasHirt
requested changes
Feb 26, 2020
added 2 commits
February 26, 2020 16:38
Added popup with reshare information which lists the resharers, their avatar and additional info. Refactored the share/collaborator object to have a clearer distinction between recipient/collaborator, owner and file owner, which eases the manipulation that is needed in some places where all fields are copied over for the resharers and owner.
The info object was just the dirty object returned by the API. Now that the relevant data has been copied to the parent object in a cleaner manner, we don't need to pass it in any more.
d7205e9 to
b0562df
Compare
|
@LukasHirt all comments addressed, can we merge ? |
LukasHirt
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For received shares, the resharers user display names are now shown
on top of the owner entry in the collaborators list, with a reshare
icon, instead of having their own entry in the collaborators list.
Moved reshare related tests to the reshare feature file.
Related Issue
Motivation and Context
Based on feedback after reviewing the feature.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: