Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display breadcrumb if rootFolder is set with no value #2811

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Display breadcrumb if rootFolder is set with no value #2811

merged 1 commit into from
Jan 7, 2020

Conversation

LukasHirt
Copy link
Collaborator

Description

In case the root folder has been set with no value, keep the first item in the breadcrumbs.

Related Issue

How Has This Been Tested?

  • test environment: Manually
  1. Set the rootFolder in config.json to ""
  2. Navigate into a subfolder

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Jan 3, 2020
@LukasHirt LukasHirt self-assigned this Jan 3, 2020
LukasHirt
LukasHirt commented Jan 3, 2020
View reviewed changes
tests/acceptance/features/webUIFiles/breadcrumb.feature
Given the property "rootFolder" has been set to "" in phoenix config file
And user "user1" has logged in using the webUI
When the user opens folder "simple-folder" using the webUI
# Then breadcrumb for folder "simple-folder" should be displayed on the webUI
Then there should be no breadcrumb displayed on the webUI
Then breadcrumb for folder "simple-folder" should be displayed on the webUI
When the user opens folder "simple-empty-folder" using the webUI
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haribhandari07 Should we still keep also the steps for "simple-empty-folder"? Or was it only temporarily until the issue is solved?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasHirt I think we can remove steps for simple-empty-folder as the scenario is only for folder one level below the root folder

haribhandari07
haribhandari07 reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@haribhandari07 haribhandari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PVince81
PVince81 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 4fd86f4 into master Jan 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/root-folder-breadcrumb branch January 7, 2020 08:24
@LukasHirt LukasHirt mentioned this pull request Jan 7, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haribhandari07 haribhandari07 haribhandari07 left review comments

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

breadcrumb is not seen one level below the root directory if rootFolder is set
3 participants
@LukasHirt @PVince81 @haribhandari07