Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acceptance test to filter files and folders using keyword in the files page #2592

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Add acceptance test to filter files and folders using keyword in the files page #2592

merged 1 commit into from
Dec 12, 2019

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Nov 29, 2019 •
edited
Loading

Description

Add acceptance test to filter files and folders and hidden elements using keyword in files page

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@jasson99 jasson99 self-assigned this Nov 29, 2019
@jasson99 jasson99 force-pushed the filterFilesFoldersUsingKeyword branch from 75c370b to 0070c43 Compare December 3, 2019 06:28
@jasson99 jasson99 marked this pull request as ready for review December 3, 2019 06:29
@jasson99 jasson99 changed the title Add acceptance test to filter files and folders using keyword Add acceptance test to filter files and folders using keyword in the files page Dec 3, 2019
skshetry
skshetry previously requested changes Dec 4, 2019
View reviewed changes
Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. But, I'd like this to be DRY, so, please try to remove duplications.

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6983/

20191204-121703-025.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6990/

20191205-053934-735.png
20191205-054017-569.png

@skshetry skshetry added Status:Needs-Review Needs review from a maintainer and removed Status:In-Progress labels Dec 5, 2019
@kiranparajuli589
Copy link
Contributor

LGTM 🚀

individual-it
individual-it requested changes Dec 6, 2019
View reviewed changes
@ownclouders
Copy link
Contributor

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7008/

20191206-052640-648.png
20191206-052734-048.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7032/

20191209-051438-418.png
20191209-051502-366.png

individual-it
individual-it requested changes Dec 10, 2019
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions to the step definitions, please also adjust the other ones, that don't have comments accordingly

@skshetry skshetry mentioned this pull request Dec 10, 2019
Closed
17 tasks
@individual-it
Copy link
Member

LGTM, @phil-davis can you please have a look at the sentences, to see if they are proper English

@jasson99 jasson99 force-pushed the filterFilesFoldersUsingKeyword branch from d47cbbb to 718af9e Compare December 11, 2019 04:45
individual-it
individual-it previously approved these changes Dec 11, 2019
View reviewed changes
@jasson99 jasson99 dismissed individual-it’s stale review December 11, 2019 10:28

some changes required

@jasson99 jasson99 force-pushed the filterFilesFoldersUsingKeyword branch from ee007ef to 24bd2b9 Compare December 11, 2019 10:39
haribhandari07
haribhandari07 approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@haribhandari07 haribhandari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haribhandari07 haribhandari07 merged commit f0774a1 into master Dec 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the filterFilesFoldersUsingKeyword branch December 12, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@haribhandari07 haribhandari07 haribhandari07 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@skshetry skshetry Awaiting requested review from skshetry

@dpakach dpakach Awaiting requested review from dpakach

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@jasson99 jasson99

Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add acceptance tests to filter files, folders and hidden elements using keyword in the files page
7 participants
@jasson99 @ownclouders @kiranparajuli589 @individual-it @skshetry @dpakach @haribhandari07