Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading of avatars fails with 500 error #4610

Closed
hurradieweltgehtunter opened this issue Jan 14, 2021 · 3 comments · Fixed by #4849
Closed

Loading of avatars fails with 500 error #4610

hurradieweltgehtunter opened this issue Jan 14, 2021 · 3 comments · Fixed by #4849

Comments

@hurradieweltgehtunter
Copy link
Contributor

hurradieweltgehtunter commented Jan 14, 2021

Steps to reproduce

  1. Load any file list where column "owner" or "shared with" is present (e.g. "Shared with me " or "shared with others")
  2. AJAX Calls to load avatars fail (see dev console)

Expected behaviour

500 error should not happen

Actual behaviour

GET https://cloudurl.com//remote.php/dav/avatars/username/128.png fails with 500 status

Browser log

Error loading avatar image for user "archive":  Unexpected status code 500 core.bundle.js:366:52759
    setUser https://cloudurl.com/index.php/apps/web/core/core.bundle.js:366
@hurradieweltgehtunter
Copy link
Contributor Author

hurradieweltgehtunter commented Jan 14, 2021

Just saw that the avatar URL has a double slash:
cloudurl.com // remote.php/dav/avatars/username/128.png

Removing one slash manually and resending the request makes it return with a 404 (which might be because the user I tested with has no avatar). Anyhow, 404 is much better than 500.

@individual-it
Copy link
Member

500 should not be returned anyway, if the client sends a wrong request the server should not return 500

ToDo QA-team:

  • reproduce in what case 500 error are returned
  • create (API) tests for that cases

individual-it added a commit that referenced this issue Feb 26, 2021
the topbad changes issue is tracked in #4610
@individual-it
Copy link
Member

for me https://localhost:9200//remote.php/dav/avatars/admin/128.png is requested and 404 is returned
I've updated the topBar image in the tests here: #4773

individual-it added a commit that referenced this issue Feb 27, 2021
the topbad changes issue is tracked in #4610
@dschmidt dschmidt mentioned this issue Mar 24, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants