Merge pull request #2303 from jasson99/AutocompletionForNonExistingUs…

…ersOrGroups Acceptance test to assert autocompletion isnt present for non-existin…
owncloud · Oct 25, 2019 · b6419a8 · b6419a8
2 parents e784613 + ce94f0f
commit b6419a8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/tests/acceptance/features/webUISharingInternalUsers/shareAutocompletion.feature b/tests/acceptance/features/webUISharingInternalUsers/shareAutocompletion.feature
@@ -48,14 +48,12 @@ Feature: Autocompletion of share-with names
     But only users and groups that contain the string "fi" in their name or displayname should be listed in the autocomplete list on the webUI
     And the users own name should not be listed in the autocomplete list on the webUI
 
-  @skip @yetToImplement
   Scenario: autocompletion for a pattern that does not match any user or group
     Given user "regularuser" has logged in using the webUI
     And the user has browsed to the files page
     And the user has opened the share dialog for folder "simple-folder"
     When the user types "doesnotexist" in the share-with-field
-    Then a tooltip with the text "No users or groups found for doesnotexist" should be shown near the share-with-field on the webUI
-    And the autocomplete list should not be displayed on the webUI
+    Then the autocomplete list should not be displayed on the webUI
 
   @skip @yetToImplement
   Scenario: autocomplete short user/display names when completely typed

diff --git a/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js b/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
@@ -418,6 +418,9 @@ module.exports = {
      */
     getUserSharePostfix: function () {
       return userSharePostfix
+    },
+    assertAutocompleteListIsNotVisible: function () {
+      return this.waitForElementNotVisible('@sharingAutoCompleteDropDown')
     }
   },
   elements: {

diff --git a/tests/acceptance/stepDefinitions/sharingContext.js b/tests/acceptance/stepDefinitions/sharingContext.js
@@ -464,3 +464,6 @@ Then('the file {string} should be in {string} state on the webUI after a page re
   await client.refresh()
   return client.page.sharedWithMePage().assertDesiredStatusIsPresent(filename, status)
 })
+Then('the autocomplete list should not be displayed on the webUI', function () {
+  return client.page.FilesPageElement.sharingDialog().assertAutocompleteListIsNotVisible()
+})