Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add longer group names added in core 30798 #222

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

phil-davis
Copy link
Contributor

Core PR owncloud/core#30798 used some different and longer group names in acceptance tests that check sharing autocompletion, because now there is a default minimum for that autocompletion lookup and so existing group and user names for tests need to be a decent length.

We can add those here, and also need to keep the other "grp1"... names that are used elsewhere in other acceptance tests. It should all pass with both sets of test groups existing - CI will know.

@phil-davis phil-davis added this to the development milestone Apr 5, 2018
@phil-davis phil-davis self-assigned this Apr 5, 2018
@phil-davis phil-davis requested a review from individual-it April 5, 2018 02:53
@phil-davis phil-davis mentioned this pull request Apr 5, 2018
@codecov-io
Copy link

codecov-io commented Apr 5, 2018

Codecov Report

Merging #222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #222   +/-   ##
=========================================
  Coverage     34.61%   34.61%           
  Complexity     1375     1375           
=========================================
  Files            32       32           
  Lines          3975     3975           
=========================================
  Hits           1376     1376           
  Misses         2599     2599

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c9d63...5508fd4. Read the comment docs.

@phil-davis phil-davis merged commit 65b7cb2 into master Apr 5, 2018
@phil-davis phil-davis deleted the update-group-names-in-acceptance-tests branch April 5, 2018 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants