Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hint for max search term length #105

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Add hint for max search term length #105

merged 2 commits into from
Jun 7, 2017

Conversation

tomneedham
Copy link
Contributor

@tomneedham tomneedham requested review from butonic and jvillafanez June 5, 2017 15:05
@jvillafanez
Copy link
Member

What is limited is the value of the attribute, not the attribute.

What could happen if the length is greater that 191 chars? Taking into account admins won't have full control over it, they should know the risk.

@tomneedham
Copy link
Contributor Author

What could happen if the length is greater that 191 chars? Taking into account admins won't have full control over it, they should know the risk.

truncated

@jvillafanez
Copy link
Member

👍

@tomneedham tomneedham merged commit 39197ea into master Jun 7, 2017
@tomneedham tomneedham deleted the search-term-advice branch June 7, 2017 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic Awaiting requested review from butonic

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomneedham @jvillafanez