Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #63, do not implement set method for entity property #66

Merged
merged 1 commit into from
Sep 28, 2018
Merged

fix for #63, do not implement set method for entity property #66

merged 1 commit into from
Sep 28, 2018

Conversation

karakayasemi
Copy link
Contributor

Fix for #59 . Entity method implementations are reverted. I tested functionalities in my local.

@karakayasemi karakayasemi self-assigned this Sep 28, 2018
@PVince81
Copy link

explanation for the fix here #59 (comment)

PVince81
PVince81 approved these changes Sep 28, 2018
View reviewed changes
Copy link

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit e2fe46c into master Sep 28, 2018
@PVince81 PVince81 deleted the fix-qa-error branch September 28, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@karakayasemi karakayasemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karakayasemi @PVince81