Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Change: Move dependencies to peerDependencies #979

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Feb 3, 2022

Suggestion to align the used versions of named packages (for the filepicker and web) and reduce the bundle size (e.g. currently, web ships with two different axios versions in its bundle)

Fixes #972

Please don't merge, we'll have to test for capability of version ranges first should be good to go since owncloud/web#6287 has a green web CI with the previous breaking changes

@pascalwengerter pascalwengerter force-pushed the peerDependencies branch 3 times, most recently from 6a7bff8 to 84c3e4c Compare February 3, 2022 17:23
@pascalwengerter pascalwengerter marked this pull request as ready for review February 8, 2022 10:28
@pascalwengerter pascalwengerter changed the title Change: Move axios, semver & uuid to peerDependencies Change: Move dependencies to peerDependencies Feb 8, 2022
README.md Outdated
@@ -1,5 +1,4 @@
[![Build Status](https://travis-ci.org/owncloud/owncloud-sdk.svg?branch=master)](https://travis-ci.org/owncloud/owncloud-sdk)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis CI ref should also be removed, since the last build ran 3 years ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye 👀

changelog/unreleased/change-peerdependencies Show resolved Hide resolved
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pascalwengerter pascalwengerter merged commit 255a7d9 into master Feb 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the peerDependencies branch February 8, 2022 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make axios a peer-dependency
2 participants