-
Notifications
You must be signed in to change notification settings - Fork 19
Fixed prop mutation, wrong event and confirm button protection in the modal #741
Conversation
49e08f1
to
b89c580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaah, the intention is, to emit a type
event on value changes coming from v-model
, correct? In that case you are doing some extra steps that could be avoided.
One more thing: I don't see an initializer for $_ocModal_input_value
variable. You need to set that in the mounted
lifecycle step, right?
Why not just emit |
This is done via the watcher.
Makes sense, will do 😉 |
…confirm in case of error
43699b9
to
d53f55e
Compare
@kulmann Ready for next review 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
Properly handle input value via v-model, use
input
event and disable confirm button in case of an error.