-
Notifications
You must be signed in to change notification settings - Fork 19
Added docs about escaping translations #639
Conversation
LukasHirt
commented
Feb 13, 2020
•
edited
Loading
edited
@C0rby for some reason I can't add you as a reviewer because it doesn't find you there 🤷♂ Pls check these docs as well 🙏 |
After reading the explanation it doesn't feel clear enough. Wasn't this about avoiding double escaping ? Is the undesirable result the double escaping ? Might be good to be clear about this, because I usually shiver when I read disabling escaping for user controlled values. So we better make sure we are still on the safe side and say so explicitly (probably the thing about the mustache syntax) |
Is this something for the design system? We have no translations in here and we are also not forcing any project on the tooling. From my pov this needs to go into the docs for phoenix .... somewhere ..... |
I'll try to go more into details 😉 |
@DeepDiver1975 This was discussed recently and the reasoning behind this is to have the guidelines united as much as possible and since we are already including accessibility and design ones there (plus some internationalization already as well), seems ok to have there also parts about the actual code. |
dd65c99
to
eafdbc0
Compare
@PVince81 Docs adjusted. |
I also have mixed feelings about this but agree that having all in one place is slightly better. |
thinking... adding the docs to Phoenix core will not help getting awareness for when we split Phoenix files and other extensions, as we'd need to duplicate the docs to these repos if they all use easygettext. and some extensions might not use easygettext at all. anyway, existing doc is better than no doc at all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
raised #642 |