Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Align sizes of oc-spinner with those of oc-icon #633

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Align sizes of oc-spinner with those of oc-icon #633

merged 1 commit into from
Feb 7, 2020

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Feb 6, 2020

Fix sizes of oc-spinner, see #631

Also introduced more sizes. xsmall for oc-icon and xsmall and xxlarge for oc-spinner, so that both components have the same size options, as well as producing same size html.

@kulmann kulmann requested a review from PVince81 February 6, 2020 21:14
@kulmann kulmann self-assigned this Feb 6, 2020
PVince81
PVince81 approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 6af38c3 into master Feb 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the align-icon-and-spinner-sizes branch February 7, 2020 08:27
tboerger pushed a commit that referenced this pull request Feb 7, 2020
commit 6af38c3
9cae940 
Merge: 05620ec e265e6e
Author: Vincent Petry <pvince81@owncloud.com>
Date:   Fri Feb 7 09:27:20 2020 +0100

    Merge pull request #633 from owncloud/align-icon-and-spinner-sizes

    Align sizes of oc-spinner with those of oc-icon
@kulmann kulmann mentioned this pull request Feb 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@kulmann kulmann

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @PVince81