Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Feature/visually hidden helper class #498

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

marcus-herrmann
Copy link
Contributor

For phoenix PR #2162

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2019

CLA assistant check
All committers have signed the CLA.

@DeepDiver1975
Copy link
Member

We need to think about how to add all oc-* classes to the documentation....

@marcus-herrmann marcus-herrmann force-pushed the feature/visually-hidden-helper-class branch from 99a2ffb to c80e430 Compare October 7, 2019 09:39
@marcus-herrmann
Copy link
Contributor Author

Also manually squished.

@marcus-herrmann marcus-herrmann force-pushed the feature/visually-hidden-helper-class branch from c80e430 to 717271b Compare October 7, 2019 14:45
@marcus-herrmann
Copy link
Contributor Author

@DeepDiver1975 Updated this PR with a suggestion for documenting helper classes.

Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@LukasHirt LukasHirt merged commit f8a53fe into master Oct 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/visually-hidden-helper-class branch October 8, 2019 15:33
tboerger pushed a commit that referenced this pull request Oct 8, 2019
Merge: 813f7d9 717271b
Author: Lukas Hirt <lhirt@owncloud.com>
Date:   Tue Oct 8 17:33:16 2019 +0200

    Merge pull request #498 from owncloud/feature/visually-hidden-helper-class

    Feature/visually hidden helper class
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants