Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Use oc colors for selected background and deselect icon #2262

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jul 20, 2022

Description

Enhancement: OcSelect dark mode improvements

We've improved the visual appearance of the OcSelect component in dark mode,
now the selected items have an adjusted color and are easier to read.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 20, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

src/components/atoms/OcSelect/OcSelect.vue Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from kulmann July 20, 2022 12:36
@kulmann kulmann merged commit 521447e into master Jul 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the web/issues/7269 branch July 20, 2022 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't see the name of the group in dark mode theme
2 participants