-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
@@ -0,0 +1,6 @@ | |||
Change: Remove click event on OcIcon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO not a change, but an enhancement, maybe even just a bugfix. Before this PR the click handler on ocIcon would be used like this:
<oc-icon @click="someCallback" />
Since the click handler was living on the root component of the template, writing the code above would still emit a click event like before, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can still add an event handler like the someCallback
example you provided. In theory it's a change because someone somewhere out there might have something listening on an OcIcon emitting a click event, but can re-scope the changelog item if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the only way to listen to that click
event is by adding a click handler like in the example above. Or could also be that I'm just missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I am? 🤔 let me change it to a bugfix changelog then
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Extracted from #2165