This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Implement an indeterminate state for the progress bar #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
suggested changes
Jun 14, 2022
kulmann
reviewed
Jun 14, 2022
| required: false, | ||
| default: undefined, | ||
| validator: value => { | ||
| return value >= 0 |
There was a problem hiding this comment.
Doesn't behave correctly:
undefinedis valid but fails in validation- 0 is invalid but succeeds in validation
There was a problem hiding this comment.
Ahh right. value > 0 should do the trick though, right? Or am I missing something? 🤔 You can still set undefined with this validator.
There was a problem hiding this comment.
Huh? undefined > 0 evaluates to false for me
There was a problem hiding this comment.
maybe it doesn't trigger the validator at all since it's the default. that might be...
There was a problem hiding this comment.
maybe it doesn't trigger the validator at all since it's the default. that might be...
Yes that's what I meant :D The check itself would return false of course
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added an indeterminate state to the progress bar.
I've decided to build the indeterminate state myself (okay, with quite some help from StackOverflow :D) because the integration of Vuetify is a bit more complex than I anticipated. We can still do this later if neccessary.
Related Issue
Needed for owncloud/web#7105
Screenshots (if appropriate):
Types of changes