Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Redesign OcModal, fix missing icons in OcModal docs #1953

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Redesign OcModal, fix missing icons in OcModal docs #1953

merged 1 commit into from
Feb 10, 2022

Conversation

pascalwengerter
Copy link
Contributor

Description

See changelog

@pascalwengerter pascalwengerter force-pushed the redesign-and-fix-oc-modal branch from 84c083b to ca04163 Compare February 10, 2022 10:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter mentioned this pull request Feb 10, 2022
Closed
24 tasks
kulmann
kulmann approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually liked having the modal header in the respective variation colors. But that can be discussed separately. This is a huge improvement, so let's get it merged and released.

@kulmann kulmann merged commit a5bdf84 into master Feb 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the redesign-and-fix-oc-modal branch February 10, 2022 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalwengerter @kulmann