Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Pass folderLink to OCResource component #1913

Merged
merged 14 commits into from
Feb 3, 2022
Merged

Pass folderLink to OCResource component #1913

merged 14 commits into from
Feb 3, 2022

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jan 28, 2022 •
edited
Loading

Description

Change: Pass folderLink to OcResource component

For more flexibility, the folderLink needs to be passed to the OcResource component

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

Open tasks:

  • ...

pascalwengerter
pascalwengerter suggested changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only merge when the corresponding PR in web is close to its finalization to not block the ODS in the meantime 🤓

@JammingBen JammingBen force-pushed the pass-folder-link branch 2 times, most recently from e82841a to 56a22ee Compare February 3, 2022 12:38
kulmann
kulmann reviewed Feb 3, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OcResource has a parentFolderLinkPath and a folderLink which previously both relied on the target route. Adding one property for each seems weird. What about passing a callback instead which handles building a router link from a resource path?

pascalwengerter
pascalwengerter reviewed Feb 3, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
pascalwengerter
pascalwengerter approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 62a4516 into master Feb 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the pass-folder-link branch February 3, 2022 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @kulmann @pascalwengerter @JammingBen