Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Lazy table cells #1848

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Lazy table cells #1848

merged 1 commit into from
Dec 30, 2021

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Dec 28, 2021

Description

primary change int this pr is the introduction of lazy table cells, on top we've removed the implicit ODS registration for the global VUE instance and made the vue composition-api available.

to get a detailed overview of what changed please read the individual changelogs.

Please wait for the new Design related PR's before merging to master

Related Issue

Motivation and Context

be able to render larger amount of table data

How Has This Been Tested?

  • unit-tests
  • manual-tests

Screenshots (if appropriate):

Bildschirmfoto 2021-12-28 um 13 56 37

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added

@fschade fschade self-assigned this Dec 28, 2021
@fschade fschade force-pushed the lazy-table-cells branch 2 times, most recently from dd1798c to 2c67682 Compare December 28, 2021 13:34
pascalwengerter
pascalwengerter reviewed Dec 28, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge in current state, needs a rebase on master first 😬

kulmann
kulmann reviewed Dec 28, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nit picks on the changelog

changelog/unreleased/enhancement-lazy-table-cells Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-lazy-table-cells Outdated Show resolved Hide resolved
@kulmann
Copy link
Contributor

kulmann commented Dec 28, 2021 •
edited
Loading

@fschade shouldn't the target branch for merge be the prepare-12.0.0-release branch instead of master? We could approve & merge it into the release branch, make another 12.0.0 release and use it in web to not be blocked by redesign things happening on the ODS master.

@fschade
remove implicit ODS registration
331bfcc 
add vue-composition-api
add feature to render table cells lazy
@fschade fschade changed the base branch from master to prepare-12.0.0-release December 29, 2021 12:40
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

27.0% 27.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😍

@kulmann kulmann merged commit 4d9af1b into prepare-12.0.0-release Dec 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the lazy-table-cells branch December 30, 2021 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@fschade fschade

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve rendering time in file views
3 participants
@fschade @kulmann @pascalwengerter