Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add Ghost Element for Drag & Drop move #1754

Merged
merged 6 commits into from
Nov 9, 2021
Merged

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Nov 3, 2021

Description

See owncloud/web#5788

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Nov 3, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the feat-drag-drop-ghost-element branch from a1d26af to 6deeb27 Compare November 3, 2021 14:27
@lookacat lookacat force-pushed the feat-drag-drop-ghost-element branch from 6deeb27 to ad04922 Compare November 3, 2021 14:28
@lookacat lookacat changed the title implement ghost element Add Ghost Element for Drag & Drop move Nov 3, 2021
@lookacat lookacat marked this pull request as ready for review November 3, 2021 14:41
@lookacat lookacat requested a review from kulmann as a code owner November 3, 2021 14:41
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things. But in general: wow! Awesome solution and improvement! 🥳 Looking forward to getting this merged.

src/components/molecules/OcTable/OcTable.vue Outdated Show resolved Hide resolved
src/components/molecules/OcTable/OcTable.vue Outdated Show resolved Hide resolved
@lookacat lookacat force-pushed the feat-drag-drop-ghost-element branch 2 times, most recently from 4d2f731 to 9098c79 Compare November 3, 2021 15:18
@lookacat lookacat force-pushed the feat-drag-drop-ghost-element branch from 9098c79 to cd3fbf2 Compare November 3, 2021 16:28
@lookacat lookacat requested a review from kulmann November 3, 2021 16:28
@lookacat
Copy link
Contributor Author

lookacat commented Nov 4, 2021

@pascalwengerter @kulmann In case you a wondering why i set the ghost elements position to be outside of the viewport instead of removing it after, if I remove the element after setting the drag image the drag image gets also removed, if i set the display none it does the same. Sadly I couldn't find a less hacky way.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to think about regarding a11y, otherwise LGTM 👍 Also checked it with a local link. Worked well for me.

src/components/molecules/OcTable/OcTable.vue Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

12.5% 12.5% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants