-
Notifications
You must be signed in to change notification settings - Fork 19
Add Ghost Element for Drag & Drop move #1754
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
a1d26af
to
6deeb27
Compare
6deeb27
to
ad04922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things. But in general: wow! Awesome solution and improvement! 🥳 Looking forward to getting this merged.
4d2f731
to
9098c79
Compare
9098c79
to
cd3fbf2
Compare
@pascalwengerter @kulmann In case you a wondering why i set the ghost elements position to be outside of the viewport instead of removing it after, if I remove the element after setting the drag image the drag image gets also removed, if i set the display none it does the same. Sadly I couldn't find a less hacky way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to think about regarding a11y, otherwise LGTM 👍 Also checked it with a local link. Worked well for me.
SonarCloud Quality Gate failed. |
Description
See owncloud/web#5788
Types of changes
Checklist: