This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
added unit tests for OcAutocomplete component #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
f43af46 to
c64cee8
Compare
38 tasks
individual-it
suggested changes
Jun 30, 2021
| const descriptionMessageElement = wrapper.find(selectors.message) | ||
| expect(descriptionMessageElement.exists()).toBeTruthy() | ||
| expect(descriptionMessageElement.isVisible()).toBeTruthy() | ||
| expect(descriptionMessageElement.get("span").text()).toBe("Help Text") |
There was a problem hiding this comment.
can we do without the span? to not depend on that implementation detail?
Suggested change
| expect(descriptionMessageElement.get("span").text()).toBe("Help Text") | |
| expect(descriptionMessageElement.text()).toBe("Help Text") |
There was a problem hiding this comment.
to assert text, we can actually.
but for class we've to get the span el
c64cee8 to
56cfb54
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
individual-it
approved these changes
Jul 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added unit test for
OcAutocompletecomponentRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: