This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Add breakpoints to theming initialization #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
Something to keep in mind - css custom props cannot be used in media queries as those are not part of the |
LukasHirt
approved these changes
Jun 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Technically a bugfix but since we haven't communicated the theme-ability of breakpoints it can count as a feature 👹
Motivation and Context
We have breakpoint CSS props and the ability to set custom CSS props via theming but were missing out on initializing (possibly present) breakpoint variables from a theming config passed by a ODS user