Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add aria properties to radio input #1148

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Add aria properties to radio input #1148

merged 1 commit into from
Mar 16, 2021

Conversation

AlexAndBear
Copy link

Add id and for properties to label
Add aria-checked, aria-labelledby, aria-disabled property to input

@AlexAndBear AlexAndBear requested a review from LukasHirt as a code owner March 15, 2021 10:18
@AlexAndBear AlexAndBear self-assigned this Mar 15, 2021
@AlexAndBear AlexAndBear added accessibility enhancement New feature or request labels Mar 15, 2021
@AlexAndBear
Copy link
Author

@kulmann, unfortunately, I found no possibility to set the checked property to the input element, I only can set it from outside the component, set it inside the component, does not have any effect.

changelog/unreleased/radio-acessibility Outdated Show resolved Hide resolved
src/components/OcRadio.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from kulmann March 16, 2021 14:03
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kulmann kulmann merged commit 3030bca into master Mar 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the radio-acessibility branch March 16, 2021 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants