Simple Ocis Binary

[refs]

Simple Ocis

To generate the simple-ocis binary:

TAGS=simple make build

run it:

./bin/ocis server

Services running

com.owncloud.api
com.owncloud.api.hello
com.owncloud.http.broker
com.owncloud.proxy
com.owncloud.registry
com.owncloud.router
com.owncloud.runtime
com.owncloud.web
com.owncloud.web.hello
com.owncloud.web.konnectd
com.owncloud.web.phoenix

Build ocis with the subset of services for easy extensions development.

I also went ahead and disabled some services I found we don't need at this stage, not only for simple ocis but for the entire binary.

TODO

• update docs

[butonic]

yep works!

[butonic]

fixes #75

[butonic]

for ocis simple we want to change the PhoenixCommand ... or introduce a PhoenixSimpleCommand that uses a different build flag ... not sure how to minimize code duplication.

	cfg.Phoenix.Phoenix.Config.Apps = []string{}
	cfg.Phoenix.Phoenix.Config.ExternalApps = []svcconfig.ExternalApp{
		svcconfig.ExternalApp{
			Name: "hello",
			Path: "http://localhost:9105/hello.js",
			Config: map[string]interface{}{
				"url": "http://localhost:9105",
			},
		},
	}

but can be done in a subsequent PR

[refs]

for ocis simple we want to change the PhoenixCommand ... or introduce a PhoenixSimpleCommand that uses a different build flag ... not sure how to minimize code duplication.

	cfg.Phoenix.Phoenix.Config.Apps = []string{}
	cfg.Phoenix.Phoenix.Config.ExternalApps = []svcconfig.ExternalApp{
		svcconfig.ExternalApp{
			Name: "hello",
			Path: "http://localhost:9105/hello.js",
			Config: map[string]interface{}{
				"url": "http://localhost:9105",
			},
		},
	}

but can be done in a subsequent PR

cannot avoid code duplication, not without getting into some nasty logic using go/build for handling conditions on build flags.

In my opinion this duplication is at least accepted for this purpose. It can however be better structured and be separated on it's own folder (pkg) but then you'd have the same. The idiom of adding the _simple suffix to the filename makes clear that this files are only included for the simple build tags.

The confusing bit is the !simple on the excluded files. For the time being this PR fulfills the requirements we desire and I propose we ship it as it is, then build on top of it.

[refs]

@butonic feeling like adding the phoenix simple command to this PR?

[butonic]

@refs no ... let us get the build tags in place first. we can then think about configuring phoenix and adding konnectd & devldap

[refs]

👍 I'll finish a few details and merge this.

[tboerger]

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- pkg/command/server_simple.go  3
- pkg/tracing/tracing.go  9
         

Complexity decreasing per file
==============================
+ pkg/command/server.go  -7
         

See the complete overview on Codacy