Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Email Notifications #6137

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Disable Email Notifications #6137

merged 4 commits into from
Apr 27, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Apr 25, 2023

Adds new setting to disable email notifications

@kobergj kobergj force-pushed the DisableEmailNotifications branch from 9db3a3e to 4450965 Compare April 25, 2023 10:39
@ownclouders
Copy link
Contributor

ownclouders commented Apr 25, 2023 •
edited
Loading

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@mmattel
Copy link
Contributor

mmattel commented Apr 26, 2023 •
edited
Loading

Needs webui documentation.
Will appear as item (when impemented by the web team) in the users personal settings.
Same location of the GDPR report request.

@mmattel mmattel mentioned this pull request Apr 26, 2023
Open
kobergj added 3 commits April 26, 2023 15:33
@kobergj
changelog
40c582a 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
add new setting to disable emails
3bf2474 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
respect disable email setting in notification service
8b7b8d0 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj force-pushed the DisableEmailNotifications branch from 4450965 to 8b7b8d0 Compare April 26, 2023 13:34
@kobergj kobergj marked this pull request as ready for review April 26, 2023 13:34
kulmann
kulmann previously requested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see my two comments being discussed. Putting a request changes here to prevent accidental merges. If my comments are bogus please dismiss my review.

@kobergj kobergj requested review from kulmann and AlexAndBear April 27, 2023 08:07
@kobergj
better naming for setting and permission
7d13ce5 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj force-pushed the DisableEmailNotifications branch from c74556d to 7d13ce5 Compare April 27, 2023 08:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

53.8% 53.8% Coverage
0.0% 0.0% Duplication

@kobergj kobergj merged commit 0c1efbd into owncloud:master Apr 27, 2023
@kobergj kobergj deleted the DisableEmailNotifications branch April 27, 2023 11:35
ownclouders pushed a commit that referenced this pull request Apr 27, 2023
@kobergj
Merge pull request #6137 from kobergj/DisableEmailNotifications
513be45 
Disable Email Notifications
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@2403905 2403905 2403905 approved these changes

@micbar micbar micbar approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kobergj @ownclouders @mmattel @kulmann @micbar @2403905 @AlexAndBear