Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Userlog Service Improvements #5699

Merged
merged 11 commits into from
Mar 9, 2023
Merged

Userlog Service Improvements #5699

merged 11 commits into from
Mar 9, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Mar 1, 2023

Improves userlog service with proper messages and enhances API

@ownclouders
Copy link
Contributor

ownclouders commented Mar 1, 2023 •
edited
Loading

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@JammingBen JammingBen mentioned this pull request Mar 3, 2023
Merged
6 tasks
@kobergj kobergj force-pushed the PolishUserlogService branch 5 times, most recently from eeed884 to 28ee5a2 Compare March 7, 2023 08:41
@kobergj kobergj mentioned this pull request Mar 7, 2023
Merged
@kulmann kulmann mentioned this pull request Mar 7, 2023
Merged
@kobergj kobergj force-pushed the PolishUserlogService branch 2 times, most recently from 4826015 to f6f91a1 Compare March 8, 2023 11:06
@JammingBen JammingBen mentioned this pull request Mar 8, 2023
Merged
5 tasks
@kobergj kobergj force-pushed the PolishUserlogService branch from f6f91a1 to fd2163e Compare March 8, 2023 14:29
@kobergj kobergj marked this pull request as ready for review March 8, 2023 15:25
micbar
micbar reviewed Mar 8, 2023
View reviewed changes
go.sum Outdated Show resolved Hide resolved
micbar
micbar approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpicks

kobergj added 11 commits March 9, 2023 09:24
@kobergj
get SpaceDisabled event working
d7b09a1 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
add a changelog
f62bfaf 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
read hardcoded templates
00c8d68 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
notify about SpaceShared
49914e1 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
notify about other events
6960da6 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
bump dockerfile go version
179d82c 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
bugfixes round one
5c2453a 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
adjust for new reva version
8a02a56 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
add capability
ee96c51 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
add shareid to message details
9255fdd 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
bump reva
c1d436a 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj force-pushed the PolishUserlogService branch from fd2163e to c1d436a Compare March 9, 2023 08:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

7.3% 7.3% Coverage
0.0% 0.0% Duplication

@kobergj kobergj merged commit bc43c31 into owncloud:master Mar 9, 2023
@kobergj kobergj deleted the PolishUserlogService branch March 9, 2023 11:04
ownclouders pushed a commit that referenced this pull request Mar 9, 2023
@kobergj
commit bc43c31
5f9c394 
Merge: 7177c41 c1d436a
Author: kobergj <jkoberg@owncloud.com>
Date:   Thu Mar 9 12:04:17 2023 +0100

    Merge pull request #5699 from kobergj/PolishUserlogService

    Userlog Service Improvements
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic left review comments

@C0rby C0rby C0rby approved these changes

@micbar micbar micbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kobergj @ownclouders @butonic @micbar @C0rby