Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] run the wopivalidator in CI #5089

Merged
merged 1 commit into from
Nov 24, 2022
Merged

[full-ci] run the wopivalidator in CI #5089

merged 1 commit into from
Nov 24, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 21, 2022 •
edited
Loading

Description

brings the wopi-validator for the personal space to CI

similar to the oC10 WOPI ci: https://github.com/owncloud/wopi/blob/272da26580b9e936d0dc7419cd2140d396f69d02/.drone.star#L2333-L2341

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Nov 21, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Nov 21, 2022 •
edited
Loading

💥 Acceptance test wopiValidatorTests-ocis failed. Further test are cancelled...

@wkloucek wkloucek mentioned this pull request Nov 21, 2022
Closed
@micbar
Copy link
Contributor

micbar commented Nov 23, 2022

Awesome! What is missing?

@wkloucek wkloucek mentioned this pull request Nov 24, 2022
Open
3 tasks
@wkloucek wkloucek changed the title run the wopivalidator in CI [full-ci] run the wopivalidator in CI Nov 24, 2022
@wkloucek wkloucek marked this pull request as ready for review November 24, 2022 09:51
@wkloucek
Copy link
Contributor Author

Awesome! What is missing?

Cleanup and follow up tickets have been missing. But it's open for reviews now!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 349cedb into owncloud:master Nov 24, 2022
@wkloucek wkloucek deleted the wopi-validator branch November 24, 2022 14:30
ownclouders pushed a commit that referenced this pull request Nov 24, 2022
@wkloucek
commit 349cedb
680c50b 
Merge: 6b8f3a5 a77a5ce
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu Nov 24 15:30:06 2022 +0100

    Merge pull request #5089 from wkloucek/wopi-validator

    [full-ci] run the wopivalidator in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @ownclouders @micbar