Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Bump core commit id #485

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 25, 2020

Gets us recent changes in core acceptance test code in run.sh etc.
e.g. owncloud/core#37841
owncloud/core#37838
owncloud/core#37844

  • do not run any tests tagged local_storage. Those are not currently useful at all, an cause BeforeScenario prblems:
  @local_storage @skipOnEncryptionType:user-keys @encryption-issue-42 @skip_on_objectstore
  Scenario Outline: Deleting a folder into external storage moves it to the trashbin                # /srv/app/testrunner/tests/acceptance/features/apiTrashbin/trashbinFilesFolders.feature:160
    Given using <dav-path> DAV path                                                                 # FeatureContext::usingOldOrNewDavPath()
    And the administrator has invoked occ command "files:scan --all"                                # OccContext::theAdministratorHasInvokedOccCommand()
    And user "Alice" has created folder "/local_storage/tmp"                                        # FeatureContext::userHasCreatedFolder()
    And user "Alice" has moved file "/textfile0.txt" to "/local_storage/tmp/textfile0.txt"          # FeatureContext::userHasMovedFile()
    When user "Alice" deletes folder "/local_storage/tmp" using the WebDAV API                      # FeatureContext::userDeletesFile()
    Then as "Alice" the folder with original path "/local_storage/tmp" should exist in the trashbin # TrashbinContext::elementIsInTrashCheckingOriginalPath()

    Examples:
      | dav-path |
      ┌─ @BeforeScenario @local_storage # FeatureContext::setupLocalStorageBefore()
      │
      ╳  could not create directory tests/acceptance/server_tmp/local_storage Unauthorized (Exception)
      │
      | old      |
      ┌─ @BeforeScenario @local_storage # FeatureContext::setupLocalStorageBefore()
      │
      ╳  could not create directory tests/acceptance/server_tmp/local_storage Unauthorized (Exception)
      │
      | new      |

and those can cause problems with later scenarios if things go badly wrong in an unfortunate order (e.g. in a way that users do not get cleanly created and deleted)

@phil-davis phil-davis self-assigned this Aug 25, 2020
@phil-davis phil-davis marked this pull request as ready for review August 25, 2020 04:41
@phil-davis
Copy link
Contributor Author

phil-davis commented Aug 25, 2020

Note: it will be nice to bump the commit id again after core PR owncloud/core#37844 is merged. (to make sure that those small changes work nicely) Then we can merge this.

Done

@phil-davis phil-davis merged commit 1e3dbaf into master Aug 25, 2020
@phil-davis phil-davis deleted the bump-core-commit-id-20200825 branch August 25, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants