Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] ApiTest. Share space via link #4241

Merged
merged 7 commits into from
Jul 21, 2022
Merged

[tests-only] ApiTest. Share space via link #4241

merged 7 commits into from
Jul 21, 2022

Conversation

ScharfViktor
Copy link
Contributor

SagarGi
SagarGi reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me 👍

tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/shareSpacesViaLink.feature Outdated Show resolved Hide resolved
@owncloud owncloud deleted a comment from update-docs bot Jul 21, 2022
@phil-davis phil-davis changed the title ApiTest. Share space via link [tests-only] ApiTest. Share space via link Jul 21, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Jul 21, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled...

@phil-davis
Copy link
Contributor

phil-davis commented Jul 21, 2022 •
edited
Loading

https://drone.owncloud.com/owncloud/ocis/13719/39/6
those cs3-api-tests are flaky - I have seen that a few times recently.

Restarted.

 Scenario: Change treesize of personal home and for only one subtree # /var/lib/cs3api-validator/etag-propagation.feature:60
    And for user "admin" the treesize of the resource with the alias "a-folder" should be 8 # /var/lib/cs3api-validator/etag-propagation.feature:66
      Error: 
	Error Trace:	assert.go:13
	            				steps.go:433
	            				value.go:556
	            				value.go:339
	            				stepdef.go:182
	            				suite.go:185
	            				suite.go:393
	            				suite.go:465
	            				run.go:119
	            				asm_amd64.s:1581
	Error:      	Not equal: 
	            	expected: 0x4
	            	actual  : 0x8

@micbar
Copy link
Contributor

micbar commented Jul 21, 2022

It is also a propagation issue, linking to #4251

SagarGi
SagarGi reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/13720/41/8

runsh: Total unexpected failed scenarios throughout the test run:
apiSpaces/copySpaces.feature:27
apiSpaces/copySpaces.feature:28

       Failed step: And for user "Brian" the space "Project" should contain these entries:
        response does not contain the entry 'newfolder/insideSpace.txt'
        Failed asserting that an array is not empty.

@ScharfViktor
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/ocis/13720/41/8

runsh: Total unexpected failed scenarios throughout the test run:
apiSpaces/copySpaces.feature:27
apiSpaces/copySpaces.feature:28

       Failed step: And for user "Brian" the space "Project" should contain these entries:
        response does not contain the entry 'newfolder/insideSpace.txt'
        Failed asserting that an array is not empty.

It's repeating locally. I'll look into it now

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit d736747 into master Jul 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the shareSpaceViaLink branch July 21, 2022 15:42
ownclouders pushed a commit that referenced this pull request Jul 21, 2022
@ScharfViktor
commit d736747
abdcfa4 
Author: Viktor Scharf <scharf.vi@gmail.com>
Date:   Thu Jul 21 17:42:39 2022 +0200

    [tests-only] ApiTest. Share space via link (#4241)

    * add test share space via link
    * Bump core commit
ownclouders pushed a commit that referenced this pull request Jul 22, 2022
@ScharfViktor
commit d736747
3b72a62 
Author: Viktor Scharf <scharf.vi@gmail.com>
Date:   Thu Jul 21 17:42:39 2022 +0200

    [tests-only] ApiTest. Share space via link (#4241)

    * add test share space via link
    * Bump core commit
dragonchaser pushed a commit that referenced this pull request Jul 27, 2022
@ScharfViktor @dragonchaser
[tests-only] ApiTest. Share space via link (#4241)
918c93c 
* add test share space via link
* Bump core commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@micbar micbar micbar approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ScharfViktor @ownclouders @phil-davis @micbar @kiranparajuli589 @SagarGi