fix accounts backend regression from #2590 #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
reviewed
Oct 27, 2021
accounts/pkg/service/v0/service.go
Outdated
| if err != nil { | ||
| logger.Fatal().Err(err).Msg("cs3 storage was configured but failed to start") | ||
| func createMetadataStorage(cfg *config.Config, logger log.Logger) (storage.Repo, error) { | ||
| switch strings.ToLower(cfg.Repo.Backend) { |
There was a problem hiding this comment.
backend was set from a lowercase string anyway, so the additional strings.ToLower should not be needed, right?
There was a problem hiding this comment.
It's ensured in the command now ;-) That's the easiest and safest way to do it. Thanks for the feedback
a89a2fd to
338701e
Compare
338701e to
f45254b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix accounts backend regression from #2590. On update from oCIS 1.13.0 to current 1.14.0-rc1 one looses the non demo accounts because the indexer is used the disk in the current oCIS